Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade core #185

Merged
merged 1 commit into from
Oct 13, 2023
Merged

upgrade core #185

merged 1 commit into from
Oct 13, 2023

Conversation

peterjan
Copy link
Member

@peterjan peterjan commented Oct 10, 2023 •
edited
Loading

This PR updates the core packages. I had to get rid of the (renterd) worker dependency. It causes a cyclic dependency preventing to update the core package in both hostd and renterd:

internal/test/renter.go:16:2: could not import go.sia.tech/renterd/worker (-: # go.sia.tech/renterd/worker
../../../go/pkg/mod/go.sia.tech/[email protected]/worker/sessionpool.go:19:29: undefined: rhpv2.RPCAppendCost

@peterjan peterjan mentioned this pull request Oct 10, 2023
Merged
@peterjan peterjan changed the title upgrade core upgrade renterd and core Oct 10, 2023
@peterjan peterjan changed the base branch from pj/upgrade-renterd to master October 10, 2023 09:30
@peterjan peterjan changed the base branch from master to pj/upgrade-renterd October 10, 2023 09:58
@peterjan peterjan changed the title upgrade renterd and core upgrade core Oct 10, 2023
Base automatically changed from pj/upgrade-renterd to master October 10, 2023 13:40
@peterjan peterjan marked this pull request as ready for review October 12, 2023 07:40
@peterjan peterjan mentioned this pull request Oct 12, 2023
Merged
@peterjan peterjan requested a review from n8maninger October 12, 2023 07:58
@peterjan peterjan self-assigned this Oct 12, 2023
@peterjan peterjan marked this pull request as draft October 12, 2023 13:51
@peterjan
Copy link
Member Author

peterjan commented Oct 12, 2023 •
edited
Loading

it's green and appears to be working, but marked it as DRAFT because upgrading renterd to this version yields a nil pointer exception in rpcLoop

edit: issue with stubs on renterd side

@peterjan peterjan marked this pull request as ready for review October 12, 2023 14:17
@peterjan peterjan requested a review from lukechampine October 12, 2023 14:28
@peterjan
Copy link
Member Author

@lukechampine, tagged you to sign off on it too

@peterjan peterjan requested a review from lukechampine October 13, 2023 13:41
@peterjan peterjan requested a review from n8maninger October 13, 2023 14:40
n8maninger
n8maninger reviewed Oct 13, 2023
View reviewed changes
rhp/v2/rhp.go Outdated Show resolved Hide resolved
wallet/wallet.go Outdated Show resolved Hide resolved
wallet/wallet.go Outdated Show resolved Hide resolved
@n8maninger n8maninger merged commit 920057f into master Oct 13, 2023
6 checks passed
@n8maninger n8maninger deleted the pj/upgrade-core branch October 13, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n8maninger n8maninger n8maninger approved these changes

@lukechampine lukechampine Awaiting requested review from lukechampine

Assignees

@peterjan peterjan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterjan @lukechampine @n8maninger